Skip to content

Check SNI/ALPN in TLS 1.2/1.3 session resumptions#10489

Merged
douzzer merged 3 commits into
wolfSSL:masterfrom
holtrop-wolfssl:zd21798
Jun 5, 2026
Merged

Check SNI/ALPN in TLS 1.2/1.3 session resumptions#10489
douzzer merged 3 commits into
wolfSSL:masterfrom
holtrop-wolfssl:zd21798

Conversation

@holtrop-wolfssl

@holtrop-wolfssl holtrop-wolfssl commented May 14, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes zd#21798

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@holtrop-wolfssl holtrop-wolfssl self-assigned this May 14, 2026
Copilot AI review requested due to automatic review settings May 14, 2026 19:49
@github-actions

github-actions Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@holtrop-wolfssl
holtrop-wolfssl force-pushed the zd21798 branch 4 times, most recently from e312881 to 9a67c0d Compare May 15, 2026 18:55
@holtrop-wolfssl

holtrop-wolfssl commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

retest this please (build hung)

julek-wolfssl
julek-wolfssl requested changes May 20, 2026
View reviewed changes

@julek-wolfssl julek-wolfssl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this check get performed for TLS 1.3 already? If you extend it with stateless ticket support then that should also be tested in test_tls.c.

Comment thread src/internal.c
@holtrop-wolfssl
holtrop-wolfssl force-pushed the zd21798 branch 2 times, most recently from 2f5f6df to eb7226c Compare May 27, 2026 16:01
julek-wolfssl
julek-wolfssl previously approved these changes May 28, 2026
View reviewed changes
@holtrop-wolfssl

holtrop-wolfssl commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

retest this please (Build wolfSSL » PRB-fips-repo-and-harness-test-v3-part2 #10052 completed: FAILURE)

@holtrop-wolfssl holtrop-wolfssl changed the title Check SNI/ALPN in TLS 1.2 stateful session ID resumption Check SNI/ALPN in TLS 1.2/1.3 session resumptions May 28, 2026
@holtrop-wolfssl

holtrop-wolfssl commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

retest this please (Build wolfSSL » PRB-fips-repo-and-harness-test-v3-part2 #10054 completed: FAILURE)

wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed May 29, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10489

Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread src/internal.c
@holtrop-wolfssl

holtrop-wolfssl commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

retest this please (Finished: FAILURE)

@douzzer douzzer added the Staged Staged for merge pending final test results and review label Jun 5, 2026
@douzzer
douzzer merged commit 764245a into wolfSSL:master Jun 5, 2026
461 checks passed
@douzzer douzzer removed the Staged Staged for merge pending final test results and review label Jun 5, 2026
@holtrop-wolfssl holtrop-wolfssl mentioned this pull request Jun 8, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left review comments
@douzzer douzzer douzzer approved these changes
@julek-wolfssl julek-wolfssl julek-wolfssl approved these changes
Copilot code review Copilot Awaiting requested review from Copilot

Assignees

@wolfSSL-Bot wolfSSL-Bot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@holtrop-wolfssl @douzzer @julek-wolfssl @wolfSSL-Fenrir-bot @wolfSSL-Bot